-
Notifications
You must be signed in to change notification settings - Fork 3
Implement "retype password" and adjust confirm password test steps #146
Conversation
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=========================================
Coverage 78.79% 78.79%
Complexity 214 214
=========================================
Files 26 26
Lines 915 915
=========================================
Hits 721 721
Misses 194 194 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
============================================
- Coverage 78.79% 78.71% -0.09%
Complexity 214 214
============================================
Files 26 26
Lines 915 916 +1
============================================
Hits 721 721
- Misses 194 195 +1
Continue to review full report at Codecov.
|
ToDo:
|
a3f881c
to
9d865f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I am fine with this change. But I think it would be nice if we have a ticket to add unit test for the js file, updated. Just in case every one agrees. I am fine with our acceptance test which would easily cover the code. 👍
drone CI has a js test fail. So I will look at that now... Existing JS tests have been adjusted. |
9d865f8
to
878f720
Compare
4fdd906
to
7c2781b
Compare
7c2781b
to
ff9d625
Compare
Issue #147