Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Implement "retype password" and adjust confirm password test steps #146

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 15, 2019

Issue #147

  • implement a "retype password" field for the case when the admin creates a new user with just a username and email address. The user follows a link from the email to a UI page where they set their first password.
  • adjust accceptance test steps that were changed by core PR Add confirm password after new password owncloud/core#30981

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #146   +/-   ##
=========================================
  Coverage     78.79%   78.79%           
  Complexity      214      214           
=========================================
  Files            26       26           
  Lines           915      915           
=========================================
  Hits            721      721           
  Misses          194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17352c7...a3f881c. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #146 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
- Coverage     78.79%   78.71%   -0.09%     
  Complexity      214      214              
============================================
  Files            26       26              
  Lines           915      916       +1     
============================================
  Hits            721      721              
- Misses          194      195       +1
Impacted Files Coverage Δ Complexity Δ
templates/new_user/setpassword.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17352c7...ff9d625. Read the comment docs.

@phil-davis phil-davis changed the title adjust confirm password test steps Implement "retype password" and adjust confirm password test steps Feb 15, 2019
@phil-davis
Copy link
Contributor Author

phil-davis commented Feb 15, 2019

ToDo:

Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I am fine with this change. But I think it would be nice if we have a ticket to add unit test for the js file, updated. Just in case every one agrees. I am fine with our acceptance test which would easily cover the code. 👍

@phil-davis
Copy link
Contributor Author

phil-davis commented Feb 15, 2019

drone CI has a js test fail. So I will look at that now...

Existing JS tests have been adjusted.

@phil-davis phil-davis force-pushed the adjust-confirm-password-test-steps branch from 9d865f8 to 878f720 Compare February 15, 2019 06:37
@phil-davis phil-davis force-pushed the adjust-confirm-password-test-steps branch 2 times, most recently from 4fdd906 to 7c2781b Compare February 15, 2019 08:32
@phil-davis phil-davis force-pushed the adjust-confirm-password-test-steps branch from 7c2781b to ff9d625 Compare February 15, 2019 08:42
@phil-davis
Copy link
Contributor Author

@PVince81 this is the equivalent code for the new user "set password" case to what @sharidas did in core master yesterday for the existing user "lost password" case.

It is covered by acceptance tests.

Please review and merge, or tell us if we have to try and add more unit tests.

@PVince81 PVince81 merged commit 2d9f525 into master Feb 15, 2019
@PVince81 PVince81 deleted the adjust-confirm-password-test-steps branch February 15, 2019 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants