This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 168
Improve the top section of config description #4387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settermjd
reviewed
Aug 27, 2018
.. Do not edit this file; edit the source file in core | ||
.. Do not edit the content of this file between _section_start and _sections_end | ||
.. The content there will be loaded and replaced via script from the source file from link above | ||
.. Any configuration changes done in this file will be overwritten on next update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/on/on the/g
settermjd
reviewed
Aug 27, 2018
.. Do not edit the content of this file between _section_start and _sections_end | ||
.. The content there will be loaded and replaced via script from the source file from link above | ||
.. Any configuration changes done in this file will be overwritten on next update | ||
.. You can of course change the common desription above this text which will be then part of the next update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/be then/then be/g
settermjd
suggested changes
Aug 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes. Otherwise, it looks good, thanks.
mmattel
force-pushed
the
Improve_config.php
branch
from
August 27, 2018 19:49
0fc012c
to
414d2a4
Compare
Added the changes as requested |
phil-davis
reviewed
Aug 28, 2018
|
||
.. note:: ownCloud may write configurations into the ``config.php`` file. | ||
These configurations may confict with identical keys already set in additional config files. | ||
Be carefule when using this capability! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/carefule/careful
mmattel
force-pushed
the
Improve_config.php
branch
from
August 28, 2018 07:10
414d2a4
to
15ff801
Compare
Added the changes as requested |
settermjd
approved these changes
Aug 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improved description text of the top section of config.sample file.
It does not touch the samples from core but only the general description.