Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

nginx fastcgi updates #3503

Merged
merged 1 commit into from
Nov 8, 2017
Merged

nginx fastcgi updates #3503

merged 1 commit into from
Nov 8, 2017

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Nov 7, 2017

This is an update of the nginx documentation to owncloud/core#29328 (Big file download from SMB via fast networks eats up memory) implementing the ability to:

  • set fastcgi_buffers 8 4k; correctly
  • adding fastcgi_ignore_headers X-Accel-Buffering;
  • removing default fastcgi_buffering off;
  • adding notes to document the reason

Imho this is complete now.
When merged, we can close owncloud/core#29328
Will also do a backport.

@PVince81 @jvillafanez

Copy link
Contributor

@jvillafanez jvillafanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@settermjd settermjd merged commit 532ba0d into master Nov 8, 2017
@settermjd settermjd deleted the nginx_updates branch November 8, 2017 09:08
@settermjd
Copy link
Contributor

@mmattel @jvillafanez thanks for making this change. It's been backported to stable10 as well.

@mmattel
Copy link
Contributor Author

mmattel commented Nov 30, 2017

For referencing: owncloud/core#29400 (Disable nginx buffering for file downloads)

@settermjd
Copy link
Contributor

@mmattel I don't quite understand your comment. Do you want that PR referenced in the changed documentation?

@mmattel
Copy link
Contributor Author

mmattel commented Dec 1, 2017

Following intention (no further action necessary):
There is a core issue (Testing 10.0.4RC1 Changelog) which refrences core 29400 as fixed issue. Having this PR now referenced to 29400, a reader can now, coming from the core PR easily find this documentation PR as additional info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big file download from SMB via fast networks eats up memory
3 participants