New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MonitorCondSince Properly #250

Open

dave-tucker opened this issue Oct 14, 2021 · 0 comments · May be fixed by #283

Collaborator

dave-tucker commented Oct 14, 2021

Currently the cache Purge() on reconnect happens in the connect() code path and is not related to the monitoring setup.

We need to change this such that:

If we are using ConditionalMontitorSinceRPC that we do not Purge the cache unless the found: bool in the RPC response is false.
Purge logic needs to be modified to work only on tables that are part of a given monitor and only rows that are part of the Condition if it's a ConditionalMonitor. This avoids deleting any data that is supposed to be used by another monitor.

The text was updated successfully, but these errors were encountered:

dcbw linked a pull request

that will close this issue

[RFC] client: honor last transaction IDs #283

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment