Support min/max number of digits for numbers in JSON Schema

[smagnan]

This would allow to mitigate some repetition issues that certain LLMs have. This should resolve #847

[rlouf]

Thank you for contributing! Would you mind adding some unit tests?

[smagnan]

Thank you for contributing! Would you mind adding some unit tests?

Will do!

Should I also address the fixme I mentioned here? (ValueError not being raised when string minLength and maxLength are invalid), or should we have an other behavior? (Ignore the keys and add a warning for example)

[smagnan]

@rlouf Added unit tests for integer bounding and number (base and bounded).

Also one fix: first digit of integers was not counted towards the bounding.
And one adjustment: base and bounded number use the same rule for decimal places: (\\.[0-9]+) instead of (\\.[0-9]*). Either can probably argued for but I am now using the same as the default one.

[rlouf]

Thanks! Looks like you need to fix the code style. Also could you rebase the branch on main?

[smagnan]

Thanks! Looks like you need to fix the code style. Also could you rebase the branch on main?

@rlouf Should be up to date with main again (did so with the github "update to main" button , which it seems merges main into my branch instead of doing a rebase).
Also ran black for proper formatting. Didn't realize I did not setup that part properly.

Hope it is all good now. Can't run the pipeline manually.

[smagnan]

No conflicts, up to date with main and all checks are passing. Should be ready to merge unless further review is necessary @rlouf

[rlouf]

Yes sorry, i haven’t had the time to pull your changes and rebase them yet will do as soon as I can. Thank you for your patience!

[smagnan]

No worries. Just wasn't sure what the process for getting PRs merged (since it seems I can add reviewers myself etc). Thanks for the fast feedback!

[rlouf]

Thank you for contributing!