-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix null byte \x00
issue in byte level fsm resulting in KeyError
in BetterFSM::FSMInfo
#930
Merged
+307
−81
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
222a5d2
Fix null byte `\x00` issue by switching to `numba.types.unicode_type`
M0gician 5ba4c2b
ensure byte fsm unicode_type compatibility by prefixing hex-bytes wit…
lapp0 22d3ddd
index token -> transition key sequence for efficient _walk_fsm
lapp0 ae9635c
pass token_transition_sequence to walk_fsm in parsing.py
lapp0 a759728
add assertions for numba behavior re: UnicodeCharSeq / unicode_type
lapp0 1e39027
Add docstrings to get_token/vocab_transition_keys, improve naming
lapp0 4468180
remove cleanup step redundant with cleanup_lark_import
lapp0 501520a
Improve naming of token and vocab transition keys in regex.py
lapp0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change isn't directly related to the PR, but fixes an issue - if the tests in
test_parsing.py
fail, it cascades and causes a large number of unrelated tests to fail.