Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to seed random sequence generations #32

Closed
rlouf opened this issue Mar 26, 2023 · 0 comments
Closed

Allow users to seed random sequence generations #32

rlouf opened this issue Mar 26, 2023 · 0 comments

Comments

@rlouf
Copy link
Member

rlouf commented Mar 26, 2023

When integrating HF's GPT2 in #30 I used python.random.seed() and python.random.randint to generate a random seed value for jax.random.PRNGKey(). This method does not allow the user to seed the sequence generation, which is however necessary for reproducibilty.

We can either:

  • Ask users to set the seed value globally;
  • Pass PRNG keys explicitly in the code.
@rlouf rlouf closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant