Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document buoyancy action / VBS #65

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Document buoyancy action / VBS #65

merged 3 commits into from
Nov 10, 2021

Conversation

chapulina
Copy link
Contributor

Part of #48

  • Document buoyancyAction and buoyancyPosition. Looking at the code history, it looks like at some point cc (cubic centimeter) was used as a unit, but AFAICT, both our plugins and the controller are consistently using cubic meters, so I documented this.
  • Made the LRAUV_example_buoyancy more flexible so we can test different volumes.
  • Checked that test_buoyancy_action has correct expectations
  • Updated the TODO in the buoyancy_engine link, becuase I believe we have a different issue now.

It would be good to have some eyes on this PR by people who have been involved in the original implementation (@mabelzhang / @arjo129 ), just to make sure I didn't miss anything related to units and the inertial TODO.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina self-assigned this Nov 5, 2021
Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we changed cc to m^3 to be consistent with Ignition units. Initially we used cc because that's how MBARI refers to the volume, both in speech and in code.

I looked over the code, but Arjo should have a look since he did the implementation.

Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested the changes to the example and it works as expected.

@chapulina chapulina merged commit a8f87c4 into main Nov 10, 2021
@chapulina chapulina deleted the chapulina/vbs branch November 10, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants