Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gz-math8: support multiple python versions #2836

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

scpeters
Copy link
Member

Part of #2834. Build bindings for both python@3.12 and python@3.13.

The following is a test of this branch, that only fails because of a brew audit error, which I am discussing with homebrew maintainers in Homebrew/brew#18552:

Test: Build Status https://build.osrfoundation.org/view/gz-ionic/job/gz_math8-install_bottle-homebrew-amd64/303/

Build bindings for both python@3.12 and python@3.13.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
It is not recommended by brew to mix runtime and
non-runtime dependencies on python versions, so follow
that pattern. This means that `brew install gz-math8`
won't install python, but our documentation instructs
users to `brew install python` anyway, so this is fine.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

that only fails because of a brew audit error, which I am discussing with homebrew maintainers in Homebrew/brew#18552

After discussion, I've decided to replace depends_on "python@3.X" with multiple depends_on "python@3.X" => [:build, :test] (ccda476), which is a pattern that passes brew audit. The main change is that brew install gz-math8 won't also install a brew version of python, but our documentation already instructs our users to do that, so I think it's ok.

Testing again:

Build bindings for both python@3.12 and python@3.13.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant