Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC minor version bump for penumbra support? #6482

Closed
Tracked by #5864
nicolaslara opened this issue Sep 21, 2023 · 4 comments
Closed
Tracked by #5864

IBC minor version bump for penumbra support? #6482

nicolaslara opened this issue Sep 21, 2023 · 4 comments
Assignees

Comments

@nicolaslara
Copy link
Contributor

nicolaslara commented Sep 21, 2023

Penumbra has contacted us asking to backport to the v4 release line a bump of ics23 to v0.10.0. This version of ics23 added the field prehash_compare_key to the SMT proof spec to support proving nonexistence in sparse trees. It was thought initially that counterparties didn't need to upgrade to this version of ics23 to open a connection with Penumbra, but it turns out that this assumption is not correct because the Cosmos SDK rejects unknown fields (so even if all the fields in the proof spec are optional, if the counterparty does not know the prehash_compare_key field, then the transaction will fail).
The connection to Osmosis is Penumbra's top priority at the moment, and they said that you would be able to do an upgrade to a new minor version of v4 in approximately 3 or 4 weeks.

ref https://osmosis-network.slack.com/archives/C03NA1C6JSX/p1695018978663109

@ValarDragon
Copy link
Member

Yeah, we should bump this IBC version!

@hdevalence
Copy link

There's a new version of ibc-go out now: cosmos/ibc-go#4710

@hdevalence
Copy link

Flagging this comment: #6643 (comment)

I think the changes in #6653 don't remove the replace directive on the ICS23 dep, which was the content of the 4.5 update, so this wouldn't be closed by #6653 as yet.

@avahowell
Copy link

The replace directive was later removed, so this can be closed now. Penumbra<>Osmosis IBC is tested and working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants