Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update car_sharing.json #4984

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Update car_sharing.json #4984

merged 1 commit into from
Mar 20, 2021

Conversation

kjonosm
Copy link
Collaborator

@kjonosm kjonosm commented Mar 20, 2021

  • Delete name tag (it is meant to name the individual carsharing station)
  • Update French location sets to metropolitan France ("fx")

- delete name tag (it is meant to name the individual carsharing station)
- update French location sets to metropolitan France ("fx")
@LaoshuBaby
Copy link
Collaborator

So why delete name tag ?

Usually chain-brand share the same name, unless we think each shop should have different name.

@LaoshuBaby
Copy link
Collaborator

Besides, thanks @kjonosm for modify fr to fx, it makes data in nsi more exact

@kjonosm
Copy link
Collaborator Author

kjonosm commented Mar 20, 2021

Usually chain-brand share the same name

This is what operator or brand is for in that context.

unless we think each shop should have different name

Shops are rather meant to be tagged with amenity=car_rental.

According to osm wiki amenity=car_sharing however is used to tag unattended car sharing stations usually located outside on reserved parking spaces.

If you check current tagging in OSM you will see that these stations are most often named after their location to better identify them.

@LaoshuBaby
Copy link
Collaborator

If it tends to be not commercial purpose, but is used as a basic facility and focuses on convenience in daily life, it is indeed some site in the public facility network, and it should be named after the site.(In this reason, I guess, ÖPNVKarte have render it in a special icon)

You are right. I understand you. This network-like car_sharing should have it individual site name as name

But can you explain by the way the pr next door, which is in #4985

@LaoshuBaby LaoshuBaby merged commit c9be309 into main Mar 20, 2021
@LaoshuBaby LaoshuBaby deleted the kjonosm-patch-1 branch March 20, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants