Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tostao' cafe brand #2969

Merged
merged 2 commits into from
Aug 18, 2019
Merged

Add Tostao' cafe brand #2969

merged 2 commits into from
Aug 18, 2019

Conversation

quincylvania
Copy link
Contributor

https://www.wikidata.org/wiki/Q60632476
http://tostaocafeypan.com/

The name stylization is a bit funky. The name on the website is TOSTAO’ Café & Pan, so I used that for official_name. I'm not sure what the index standards are for all-caps and apostrophes (' vs. ), but Tostao’ seemed more reasonable for the brand and name.

@quincylvania quincylvania added the add brand Actionable - add a brand to the index label Aug 16, 2019
@bhousel
Copy link
Member

bhousel commented Aug 18, 2019

Thanks! I usually try to avoid curly apostrophes, but there may be a few in the index.
Also the matching code now ignores punctuation so we don't need to specifically match the different variants anymore..

@bhousel bhousel merged commit 2ebce6f into master Aug 18, 2019
@bhousel bhousel deleted the tostao branch August 18, 2019 02:52
@1ec5
Copy link
Member

1ec5 commented Aug 18, 2019

Someday I’ll convince OSM to embrace curly apostrophes. 😉

In case anyone sees this and decides to straighten out apostrophes throughout the index, note that some wikipedia tags need to retain curly apostrophes due to the actual page names.

/ref 074e981#commitcomment-33896996

@bhousel
Copy link
Member

bhousel commented Aug 18, 2019

In case anyone sees this and decides to straighten out apostrophes throughout the index, note that some wikipedia tags need to retain curly apostrophes due to the actual page names.

Ok.. In this case I left them in anyway. I have no idea how they would look to a native Columbian speaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add brand Actionable - add a brand to the index
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants