-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELI does not load in latest JOSM #2388
Comments
I believe the issue is simply that https://github.com/osmlab/editor-layer-index/blob/gh-pages/scripts/convert_xml.py doesn't actually convert the category field. |
@simonpoole I can merge the PR but I need to get some clarification, does it mean whenever JOSM releases some breaking changes, we are required to keep up with them? I’m asking because bringing a new field may break other clients but I can’t tell. |
It isn't a new field, it is one that, at the time, was introduced coordinated with JOSM (that's the reason that some of the values are very JOSMish) and ELI actually requires it iirc. It is just that nobody added it to the JOSM compatible output and nobody noticed because JOSM didn't check its input. Now you do have a point wrt keeping things in sync with JOSM. For a while there was an effort to, even if neither party was and is willing to give up the parallel effort, to at least keep the widely used information and support synced and compatible so that users could use either index. I believe there is still some value to that and if it just involves fixing a trivial python script, I don't see any reason to not do so. All that said, please don't merge yet, because of a minor emergency yesterday I didn't get around to testing in particular the output needs to be checked against the XSD (obviously best that would be included in the CI, but that is likely too much work if there isn't a ready made python way of doing that, which I haven't investigated). @grischard ping |
I've fixed a number of things that failed validation (some which had "always" been wrong), can be merged now from my pov. Naturally no guarantees. |
Follow-on from #2337 which is locked
This issue is confirmed by the JOSM team who state:
Note this issue occurs on the latest version of JOSM, which I confirmed on build 19128. The JOSM team confirms this is a recent change.
From this description it appears that ELI may no longer be compatible with JOSM.
The text was updated successfully, but these errors were encountered: