-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add category value to xml output and more JOSM compatibilities fixes #2389
Conversation
So after running the output through xmlstarlet, seems as if there are five remaining issues:
|
This is due to JOSM limiting the number of points in a "shape" element to 999, potential solution: simply use a bounding box for these entries (8 as of right now), as we already have the bounding box, this means simply dropping the polygon in these cases. |
5ca8c55
to
ba75b0b
Compare
For @grischard the following seem to have polygons with more than 999 vertices Using BBOX for osmim-imagicode-usgs_250k_ant has 1222 vertices |
The name element was being set to ELIs id value, which seems to be "wrong". What is unclear is if it even makes sense to set the id value.
ba75b0b
to
37a3f23
Compare
There should be 121 vertices for SPW2021 (the only one I spot-checked). |
Sorry, that was a last minute rush before I went on vacation, I've corrected the list now. |
I hope you had a good vacation. :) Anyway, it looks like some of those high-vertices count polygons can/should be simplified. But probably not in this PR. |
This needs some testing, but likely does the trick.
Fixes #2388