-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gas stations #999
Add gas stations #999
Conversation
Looks good, thanks for adding this! Regarding the color, I wrote most of this on Slack, but reposting here for completeness: Gas stations are certainly the perfect overlap of “consumer”, “infrastructure”, and “transport”, so the color they should have is definitely ambiguous under the current guidance. IMO down the line we might want separate colors for food and shops, rather than one “consumer” color. Maybe gas could be this future shop color? Until then, I think your choice of "consumer" orange is fine, though I don't think blue or mauve would be egregiously wrong either. |
I made the icon 1 pixel shorter to--in my view--better match the visual weight of the other icons we have so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Well done.
Thank you for your contribution! |
This PR adds an icon for gas stations. I feel like this is an important one to have on an America-centric map. The icon itself is fairly standard, I think, for what Americans would expect to see representing a gas station and falls into the "consumer" color category. I chose to select the
fuel
subclass because I saw discussion in openmaptiles/openmaptiles#1544 to addcharging_station
to thefuel
class. Happy to discuss and/or alter any of this.Link on localhost