Add gas stations #999
Merged
Add gas stations #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claysmalley
reviewed
Dec 2, 2023
|
Looks good, thanks for adding this! Regarding the color, I wrote most of this on Slack, but reposting here for completeness: Gas stations are certainly the perfect overlap of “consumer”, “infrastructure”, and “transport”, so the color they should have is definitely ambiguous under the current guidance. IMO down the line we might want separate colors for food and shops, rather than one “consumer” color. Maybe gas could be this future shop color? Until then, I think your choice of "consumer" orange is fine, though I don't think blue or mauve would be egregiously wrong either. |
|
I made the icon 1 pixel shorter to--in my view--better match the visual weight of the other icons we have so far. |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an icon for gas stations. I feel like this is an important one to have on an America-centric map. The icon itself is fairly standard, I think, for what Americans would expect to see representing a gas station and falls into the "consumer" color category. I chose to select the
fuelsubclass because I saw discussion in openmaptiles/openmaptiles#1544 to addcharging_stationto thefuelclass. Happy to discuss and/or alter any of this.Link on localhost
