Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax node version (18.16.1 → 18.x) #967

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Relax node version (18.16.1 → 18.x) #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ jobs:
echo "EOF" >> $GITHUB_ENV
- name: Checkout PR Branch 🛎️
uses: actions/checkout@v3
- name: Use Node.js 18.16.1
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.16.1 #18.17.0 is buggy
node-version: 18.x
- name: Install and Build 🔧
# TODO: when we move shieldlib to its own repo, move shieldlib docs CI also
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
steps:
- name: Checkout 🛎️
uses: actions/checkout@v3
- name: Use Node.js 18.16.1
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.16.1 #18.17.0 is buggy
node-version: 18.x
- name: Install and Build 🔧
# TODO: when we move shieldlib to its own repo, move shieldlib docs CI also
run: |
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/test-build-mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,10 @@ jobs:
steps:
- name: Checkout 🛎️
uses: actions/checkout@v3
# Node v18.17.0, introduced July 18, 2023, introduces an error in unicode processing that breaks test cases on Ubuntu.
# See PR #905 and #908 for more details.
# If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.0.
- name: Use Node.js 18.16.1
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.16.1
node-version: 18.x
- name: Build Shield Library 🛡️
run: |
cd shieldlib
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/test-build-ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,10 @@ jobs:
steps:
- name: Checkout 🛎️
uses: actions/checkout@v3
# Node v18.17.0, introduced July 18, 2023, introduces an error in unicode processing that breaks test cases on Ubuntu.
# See PR #905 and #908 for more details.
# If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.1.
- name: Use Node.js 18.16.1
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.16.1
node-version: 18.x
- name: Build Shield Library 🛡️
run: |
cd shieldlib
Expand Down
1 change: 0 additions & 1 deletion test/spec/label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ describe("label", function () {
"Derry",
"Derry/Londonderry"
);
expectGloss("en", "L’Aquila", "L'Aquila", "L’Aquila", "L'Aquila");
});
it("glosses non-English localized name with lookalike local name", function () {
expectGloss(
Expand Down