Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention wikidata in the project's documentation. #430

Merged
merged 4 commits into from
Jun 18, 2022
Merged

Conversation

ZeLonewolf
Copy link
Member

As noted in #428, the project's documentation lacks an explicit indicator that wikidata is used as a data source.

As noted in #428, the project's documentation lacks an explicit indicator that wikidata is used as a data source.
@ZeLonewolf ZeLonewolf requested a review from 1ec5 June 18, 2022 02:43
@ZeLonewolf ZeLonewolf added the documentation Improvements or additions to documentation label Jun 18, 2022
README.md Outdated

The OpenStreetMap Americana style is built upon the [OpenMapTiles schema](https://openmaptiles.org/schema/), which includes:
* Feature data from OpenStreetMap
* Translated place name labels from [Wikidata](https://www.wikidata.org/wiki/Wikidata:Main_Page)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only places, or anything tagged with wikidata?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, just grepped the openmaptiles code base and got the full list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Natural Earth?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just added Natural Earth. Also I realize I'm missing lake labels.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, lake lines are generated from OSM so that's OK.

Add specific list of translated names
@ZeLonewolf ZeLonewolf merged commit 28772da into main Jun 18, 2022
@ZeLonewolf ZeLonewolf deleted the ZeLonewolf-patch-1 branch June 18, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants