Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shields for states of Mexico #1097

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Add shields for states of Mexico #1097

merged 6 commits into from
Jun 20, 2024

Conversation

claysmalley
Copy link
Member

@claysmalley claysmalley commented Jun 8, 2024

Fixes #404

This does not include shields for the State of Mexico, because there are two competing abbreviations for the state (EM, MEX). Waiting on the local mapping community to come to a consensus.


No incluye escudos para el Estado de México, porque existe dos abreviaturas que compiten para el estado (EM, MEX). Esperando a que la comunidad cartográfica local llegue a un consenso.

@ZeLonewolf
Copy link
Member

Jalisco state:

image

Of note, there is only a single route, in the 3-digit variety, so we have no example of what the 2-digit version looks like.

@ZeLonewolf
Copy link
Member

Looks like there is some work still to remove network names from route relation refs:

image

src/js/shield_defs.js Outdated Show resolved Hide resolved
Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sounds like we've resolved the outstanding issues.

@claysmalley claysmalley merged commit df2a52b into main Jun 20, 2024
6 checks passed
@claysmalley claysmalley deleted the clay-shields-mx-states branch June 20, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Shields of Mexico
3 participants