Adding vehicle POI icons #1027
Merged
Adding vehicle POI icons #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these look nice! Can you make sure you update the taginfo file as well? |
|
The upper screenshot looks like a great test location, can you add an entry to test/sample_locations.json so it appears in the PR Preview check? |
|
Done. |
ZeLonewolf
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an icon to render icons for
shop=car,shop=car_repair, andamenity=taxi. I wanted to handle them all in one go because they share the same base car icon, although in the end I tweaked thecar_repaircar to be a little shorter to accomodate the wrench above it. I ended up filling in the windshield after some discussion on Slack, as that seems most consistent with the bus and fuel icons. I had also wanted to create an icon forcar_washwhile I was at it, but OpenMapTiles does not support that yet. This PR makes progress on #692. Open to any feedback, discussion, or suggestions!localhost link
localhost link