Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White shield border for Irish N-road and British A-road #1026

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Blijbol
Copy link
Contributor

@Blijbol Blijbol commented Jan 7, 2024

Irish N-roads and British A-roads, both with yellow-on-green shields, generally do not seem to have any shield border within destination signs. However, signs suggest that if there is a border, it should be white:

The shields on Wikimedia Commons also have white borders:

This PR therefore changes the shield border colour from yellow to white.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The white outline doesn't look as nice as the yellow one, but I have to agree it's an accurate representation of the real world. So, it's a yes for me unless there's a convincing reason otherwise.

@claysmalley claysmalley merged commit 14bc0eb into osm-americana:main Jan 11, 2024
6 checks passed
@Blijbol Blijbol deleted the jeroen/no-yellow-border branch January 12, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants