Omit indigenous lands from park rendering #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Dec 23, 2023
src/layer/park.js
Outdated
| const parkLayerFilter = [ | ||
| "in", | ||
| ["get", "class"], | ||
| ["literal", ["nature_reserve", "national_park", "protected_area"]], |
There was a problem hiding this comment.
class can potentially be anything, based on protection_title taggified. Do we need to include other common values like protected_site and přírodní_památka_(pp)? I think excluding aboriginal_lands would be the safer and more direct fix.
There was a problem hiding this comment.
Oh, I thought I fixed that but I see that I never finished openmaptiles/openmaptiles#1491, so I'll change that to exclusion
There was a problem hiding this comment.
Changed in 9642b23.
I also see now that aboriginal_lands is not differentiated at the lowest zoom so I've also removed park layer rendering from z4 until we can get a fix.
1ec5
approved these changes
Dec 23, 2023
1ec5
changed the title
1ec5
changed the title
This was referenced Dec 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #105, this PR whitelists the allowable class values to render in the park layer only to those features that should be rendered like parks.