Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert POI handling code to Typescript and add error check and null pointer yak shave #1016

Merged
merged 6 commits into from
Mar 31, 2024

Conversation

ZeLonewolf
Copy link
Member

@ZeLonewolf ZeLonewolf commented Dec 23, 2023

This PR:

  1. Converts the POI handling code to typescript and adds typing in a couple places to help with editor code completion
  2. Adds a check to make sure the supplied POI icon name actually exists. This was a problem I actually ran into when I typo'd a POI icon name and had to follow a stack trace to figure out the problem. With this change you'll get a helpful console error message.
  3. Adds a check to make sure a webfont shield is really missing from the spritesheet before trying to remove and add it. This fixes a race condition which caused a bunch of errors to show up in the console on start.
  4. Fix for this occasional startup stack trace. It occurs in the case where the shieldJSON hasn't loaded yet, but the tiles have, and it's starting to render shields before we have the shield definition (all the more reason why we should do Compact ShieldJSON format #1015)
    image

@ZeLonewolf ZeLonewolf added enhancement New feature or request points of interest labels Dec 23, 2023
@ZeLonewolf ZeLonewolf added the bug Something isn't working label Dec 23, 2023
@ZeLonewolf ZeLonewolf changed the title Convert POI handling code to Typescript and add error check Convert POI handling code to Typescript and add error check and null pointer yak shave Dec 23, 2023
@ZeLonewolf ZeLonewolf marked this pull request as ready for review December 23, 2023 02:50
@ZeLonewolf ZeLonewolf merged commit eb64893 into main Mar 31, 2024
6 checks passed
@ZeLonewolf ZeLonewolf deleted the zlw-poi-ts branch March 31, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request points of interest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants