Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shields for Aruban road network #1012

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

Blijbol
Copy link
Contributor

@Blijbol Blijbol commented Dec 20, 2023

This adds black-on-yellow shields for road routes on Aruba. The A- or B-suffix depends on the direction of travel.

Sample road signs:

(Older road signs use white-on-blue instead of black-on-yellow.)

@claysmalley
Copy link
Member

Are shields in Aruba always fixed-width rectangles? If so, let's give them the max width of 34px.

@ZeLonewolf
Copy link
Member

Preview location (basically the whole country):
https://preview.ourmap.us/pr/1012/#map=12.41/12.51651/-69.98641

@Blijbol
Copy link
Contributor Author

Blijbol commented Dec 20, 2023

Are shields in Aruba always fixed-width rectangles?

We might need to wait for route 10 to find out? Currently they are all one digit and one letter. I imagine the shields will have to increase in width once route 10 is created.

@ZeLonewolf
Copy link
Member

There are already both 1-digit and 2-digit routes (thanks to letter suffixes). If they are both using a fixed wide width as shown in the linked pictures then I agree with a fixed wide width in the style. The examples linked are all 2-digit so I think we'd need to look at what the 1-digit version looks like.

@Blijbol
Copy link
Contributor Author

Blijbol commented Dec 20, 2023

Unfortunately, all currently existing shields are one numerical digit (1/2/3/4/5/8/9) plus one letter (A/B).

@ZeLonewolf
Copy link
Member

In the code, the Aruba shields mirror the Netherlands shields. How is with handled in mainland Dutch shields?

@Blijbol
Copy link
Contributor Author

Blijbol commented Dec 20, 2023

Netherlands mainland shields are variable-width.

@ZeLonewolf
Copy link
Member

Given the political association between The Netherlands (mainland) and Aruba, it makes sense to me that we would model the Aruba shields the same way as is presently implemented in this PR.

Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

@ZeLonewolf ZeLonewolf merged commit a30d2f4 into osm-americana:main Dec 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants