Replace ts-node with tsx #1003
Replace ts-node with tsx #1003
Conversation
apparently node 18.19.0 decided to change the (admittedly experimental) import hooks in a backwards-incompatible way. ts-node has not had a release to support this new interface, so switch to tsx which has. incidentally this also means the scripts are now compiled with esbuild instead of with typescript, but we already depend on esbuild. (and it's been a TODO to actually run tsc to typecheck everything.)
|
Need to replace ts-node calls in package.json and one ts-node call in one of the github workflows. |
|
Well, "Build PR Preview / deploy-preview" is failing at the "Install and Build Main Branch", because it is broken. |
|
Looks like there is still a |
|
This action: Needs to move up higher, before the first invocation of npm. |
|
There are also two actions labelled "deploy-preview", so one of them should probably be renamed for sanity sake when looking at output runs. |
Yes, because it switches to a different branch.
I don't disagree, but that's not directly related to this change. |
|
I believe this is safe to merge, and then main branch will be sane again |
Fix a module hook incompatibility. And hey, it's no longer "experimental" so this (facet of the house of cards) should be stable now.
Should now be able to run on any version of Node.js 18 or later.
Tested on: 18.18.2, 18.19.0, 21.4.0