Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception (panic) is not handled in the framework #57

Open
vault-thirteen opened this issue Dec 26, 2023 · 0 comments
Open

Exception (panic) is not handled in the framework #57

vault-thirteen opened this issue Dec 26, 2023 · 0 comments

Comments

@vault-thirteen
Copy link

Hello there again.
I have found another issue, and this time it is critical for me.

If an exception (panic) happens inside a handler, the application crashes.
Good frameworks use exception (panic) handling.

To fix this issue I will have to add the same deferred code to each of the handlers manually ! Not mentioning that it will take a long time to copy-paste into hundreds of handlers in numerous files of different services, it will be the the greatest violation of the DRY principle for me, while I will not be able to modify that code in one place making support of this code terrible.

I regret to say that if you do not respond soon, I will have to stop using your library.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant