Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too slow xpra drawing? #9

Open
tunatoksoz opened this issue Jan 5, 2022 · 8 comments
Open

Too slow xpra drawing? #9

tunatoksoz opened this issue Jan 5, 2022 · 8 comments
Assignees

Comments

@tunatoksoz
Copy link

I tried official xpra client, and os-js client. For some reason, os-js client (xpra-html5-client) is performing very poorly. It's like 1 frame per second or less. When I looked into the dev tools, it confirmed my suspicion of 1fps, and i noted base64 image constructions at a similar or slower rate.

Official XPRA client seems to be getting quite a bit of updates, but too sad they don't export it as an NPM'able library nor do they make it easy to use individual bits and pieces.

I will probably do some more digging, but performance difference will probably kill one of my use cases until i can identify the problem.

@andersevenrud
Copy link
Member

and i noted base64 image constructions at a similar or slower rate.

This is probably the main issue. My version of the xpra library doesn't have the video codec support that is in the official package.

I actually started rewriting the entire thing from bottom up using typescript and with way less influence from the original code. I really should look into that again... it's been quite a while since I touched that.

@tunatoksoz
Copy link
Author

From purely maintenance pov, the ideal case is xpra-team to create a library that others can use (so you can use it as is). This would help with their updates automatically getting pulled into your wrapper.

But that probably would take a long time and not sure how easy it is for them to do it (or if there's even a use for them).

Mid-way solution is probably copy paste instead of a rewrite, and building a wrapper without modifying code.

You already know these, helping you to think out loud..

For my use case due to time constraints i will probably do VNC and SPICE integration instead, and leave XPRA to be a standalone page i will link into in case i need it.

@totaam
Copy link

totaam commented Feb 23, 2022

We are going to move the https://github.com/Xpra-org/xpra-html5 client to a more modern codebase (ES6) and plan on making it more re-usable for external projects as there seems to be quite a few that are re-using it.
We are discussing how best to proceed with that, feel free to join us on this Xpra web client(s) discussion channel: https://discord.com/channels/934131122504343572/939997428696883260

@andersevenrud
Copy link
Member

Just a small update on that TS client I mentioned. I found a bit of time to do a little bit more work on it: https://github.com/andersevenrud/xpra-html5-client

@totaam Is that discord invite only or something ? I can't seem to get it. At first I thought it was something on my end, but it's been like a week and I still get "no text channels" error. I'm a total Discord noob though, so maybe there's an option or something ? I would love to join in on this.

@totaam
Copy link

totaam commented Mar 15, 2022

@andersevenrud I'm also a discord noob, but I've pinged someone who should be able to sort this out.
The channel should be public.

@totaam
Copy link

totaam commented Mar 17, 2022

@andersevenrud sorry he hasn't replied yet, how about this link:
https://discord.com/channels/934131122504343572/934131122969915517

@andersevenrud
Copy link
Member

@totaam Same problem I'm afraid.

@TijZwa
Copy link

TijZwa commented Mar 18, 2022

@andersevenrud Could you try https://discord.gg/Tv8d3ebm (within 7 days)
@totaam fyi.

@andersevenrud andersevenrud self-assigned this Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants