Skip to content

OAuth2 Redirect URL validity does not respect query parameters and host for loopback addresses

Moderate
aeneasr published GHSA-rfq3-w54c-f9q5 Oct 2, 2020

Package

github.com/ory/fosite (Go Modules)

Affected versions

v0.30.3 - v0.34.0

Patched versions

v0.34.1

Description

Impact

fosite#400 (released as v0.30.2) introduced a new feature for handling redirect URLs pointing to loopback interfaces (rfc8252#section-7.3). As part of that change new behavior was introduced which failed to respect the redirect URL's (only for loopback interfaces!) query parameters

  1. Registering a client with allowed redirect URL http://127.0.0.1/callback
  2. Performing OAuth2 flow and requesting redirect URL http://127.0.0.1/callback?bar=foo
  3. Instead of an error, the browser is redirected to http://127.0.0.1/callback?bar=foo with a potentially successful OAuth2 response.

as well as the host parameter (as long as the host is a loopback interface):

  1. Registering a client with allowed redirect URL https://example.com/callback
  2. Performing OAuth2 flow and requesting redirect URL http://127.0.0.1/callback
  3. Instead of an error, the browser is redirected to http://127.0.0.1/callback with a potentially successful OAuth2 response.

These bugs are only applicable in scenarios where the attacker has control over the loopback interface (localhost, 127.0.0.1, [::1]) where the browser performing the OAuth2 flow is running.

Patches

This vulnerability has been patched with ORY Fosite v0.34.1.

Workarounds

None.

Vector string

CVSS:3.0/AV:N/AC:L/PR:H/UI:R/S:U/C:H/I:H/A:N/E:P/RL:O/RC:C rated 6.1 severity

Severity

Moderate

CVE ID

CVE-2020-15233

Weaknesses

No CWEs

Credits