aborts when no modules present

[lockbox]

in this case under lxc on a chromebook (and probably on generic linux in a few other cases eg with no runtime modules) there is no /proc/modules, so this panic's. In this case could it just return and empty string so it would not panic, and then show an empty set of modules?

kmon/src/kernel/lkm.rs

Lines 117 to 118 in 3ed516f

	let modules_content = util::exec_cmd("sh", &["-c", &module_read_cmd])
	.expect("failed to read /proc/modules");

[orhun]

Hey, thanks for reporting!

In this case could it just return and empty string so it would not panic, and then show an empty set of modules?

Yes I agree. Would you be interested in submitting a PR to fix this?

[eld4niz]

hey, @orhun. I tried changing that mentioned line to something like this:

let modules_content = util::exec_cmd("sh", &["-c", &module_read_cmd]).unwrap_or_else(|_| String::new());

should I also add few lines for parsing part?

[lockbox]

Would also probably be worth adding a log message or something since the display is just blank

[lockbox]

hey, @orhun. I tried changing that mentioned line to something like this:

let modules_content = util::exec_cmd("sh", &["-c", &module_read_cmd]).unwrap_or_else(|_| String::new());

should I also add few lines for parsing part?

Thanks, saves me the time doing an MR lol🙏