Add permissions to conversation resolution #12961
Replies: 14 comments 3 replies
-
agree, this would make life much easier. |
Beta Was this translation helpful? Give feedback.
-
but the owner of the repo still has the full rights whether to address the PR or not, if that is in a company, then it's their internal communication that will matter |
Beta Was this translation helpful? Give feedback.
-
I also agree that such feature would provide better PR handling. But this should only be valid for comments added in request for revision. Comments added only in the spirit of comments, should not be included in this restriction. |
Beta Was this translation helpful? Give feedback.
-
Sometime while reviewing a PR I start a conversation to address a problem or a doubt. |
Beta Was this translation helpful? Give feedback.
-
This sort of feature would be really helpful for my organisation. For our review process we'd like it so that all comments that might need a problem addressing should only be resolvable by the author of the comment or by the review moderator in times of deadlock between the comment author and the review owner. This alongside requiring all comments to be resolved before the PR can be complete would be perfect |
Beta Was this translation helpful? Give feedback.
-
I would really like this feature. tracking down my conversations to see if they were answered is a pain |
Beta Was this translation helpful? Give feedback.
-
Is there any news regarding this awesome feature? |
Beta Was this translation helpful? Give feedback.
-
This is one of those features worth applying to work at GitHub, implementing, then quitting lol |
Beta Was this translation helpful? Give feedback.
-
I completely agree that there's a need. I'm just about to unresolve 175 conversations to verify the implementation of what has been done. |
Beta Was this translation helpful? Give feedback.
-
Definitely in favour of this - but obviously it should be a configurable option to be tailored to each organisation/individual's needs. I'd like the ability to lock it down so that only the person who raised the comment is able to mark it as resolved - that's the process we follow but unfortunately there's no way to enforce this. Also an admin override of some kind would probably be necessary. |
Beta Was this translation helpful? Give feedback.
-
I need this feature. Big companies with different timezone is vert handy |
Beta Was this translation helpful? Give feedback.
-
This is definitely needed. Additionally the "Require conversation resolution before merging" branch protection rule on a repository becomes fairly useless without comment resolution permissions because someone can trivially just resolve all conversations to bypass the protection rule. |
Beta Was this translation helpful? Give feedback.
-
In general the permissions of github are way too corsare grained. |
Beta Was this translation helpful? Give feedback.
-
I feel a need to restrict a person who made a PR to resolve your comments as a reviewer. |
Beta Was this translation helpful? Give feedback.
-
There should be some sort of permission system on conversation resolution. For instance, there should be an option to not allow the author of a PR to resolve conversations.
Example/use case:
John makes a PR
Bob leaves feedback in a conversation "you should fix this line"
John resolves the conversation without addressing the feedback
Bob forgets about the conversation since it is one of many conversations on the PR
If John was not able to resolve the conversation (only the PR reviewers can resolve) then this can't happen
Beta Was this translation helpful? Give feedback.
All reactions