Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General code tidy #4

Merged
merged 15 commits into from
May 29, 2020
Merged

General code tidy #4

merged 15 commits into from
May 29, 2020

Commits on May 20, 2020

  1. Avoid use of shorthand module to when referring to the Kubernetes module 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    f909a08 View commit details
    Browse the repository at this point in the history

  2. Give scripts an extension to indicate their usage 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    e02b97e View commit details
    Browse the repository at this point in the history

  3. Not necessary to open NodePorts 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    e126c3a View commit details
    Browse the repository at this point in the history

  4. Persistently disable swap 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    a2a1a0d View commit details
    Browse the repository at this point in the history

  5. Improve readability 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    0c394b2 View commit details
    Browse the repository at this point in the history

  6. Continue rename of 'module' to 'Kubernetes module' 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    b15eea1 View commit details
    Browse the repository at this point in the history

  7. Hotfix to e02b97e - Give scripts an extension to indicate their usage 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    d3f2599 View commit details
    Browse the repository at this point in the history

  8. Continue rename of 'module' to 'Kubernetes module' 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    7fd34da View commit details
    Browse the repository at this point in the history

  9. Update user facing strings to include capitalisation 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    6c19487 View commit details
    Browse the repository at this point in the history

  10. Be consistent when using double quotes for globbing 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 20, 2020
    Configuration menu
    Copy the full SHA
    58879b7 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Improve readability of user facing messages 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 21, 2020
    Configuration menu
    Copy the full SHA
    f7be445 View commit details
    Browse the repository at this point in the history

  2. Allow expansion of variables in echo 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 21, 2020
    Configuration menu
    Copy the full SHA
    7dd8b95 View commit details
    Browse the repository at this point in the history

  3. ssh-keyscan(1) matches the first hostname in a string, don't use quotes 

    Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 21, 2020
    Configuration menu
    Copy the full SHA
    eb24b87 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Merge branch 'master' into hotfix-code-tidy

    @mark-au
    mark-au authored May 28, 2020
    Configuration menu
    Copy the full SHA
    dbf6691 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Revert "Improve readability" as requested by Ali in PR oracle-terrafo… 

    …rm-modules#4

This reverts commit 0c394b2.

Signed-off-by: Mark Cram <mark.cram@oracle.com>
    @mark-au
    mark-au committed May 29, 2020
    Configuration menu
    Copy the full SHA
    196477d View commit details
    Browse the repository at this point in the history