Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story Text Size in other learner screens. #1491

Closed
5 tasks done
rt4914 opened this issue Jul 21, 2020 · 12 comments · Fixed by #5290
Closed
5 tasks done

Story Text Size in other learner screens. #1491

rt4914 opened this issue Jul 21, 2020 · 12 comments · Fixed by #5290
Assignees
@Vishwajith-Shettigar
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 21, 2020 •
edited by adhiamboperes
Loading

Currently the story text size change in settings is getting reflected in exploration / StateFragment only. But I think it should get reflected in Concept Card as well as Hints & Solution because from user perspective they are also part of exploration only.

Checklist

  • Implement in Hints & Solution
  • Implement in Concept Card
  • Implement in Question Player
  • Revision Card
  • Check that it is working on Hints & Solution of Question Player
@rt4914 rt4914 added this to the Alpha milestone Jul 21, 2020
@rt4914 rt4914 changed the title Story Text Size in Hints & Solution and Concept Card Story Text Size in other learner screens. Jul 24, 2020
@anandwana001
Copy link
Contributor

anandwana001 commented Jul 29, 2020 •
edited
Loading

Commenting for reference
We can take this issue once we resolve the current bug coming in text size setting from exploration screen.
#1540

@anandwana001 anandwana001 removed their assignment Jul 29, 2020
@anandwana001
Copy link
Contributor

anandwana001 commented Aug 4, 2020 •
edited
Loading

@rt4914 Based on Ben's comment - #1540 (comment) I think we should shift this issue to beta milestone.

@rt4914 rt4914 modified the milestones: Alpha, Beta Aug 5, 2020
@alokbharti
Copy link
Contributor

Hi @rt4914 @anandwana001 , I would like to work on Concept Card screen in this issue.

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 20, 2020

Hi @rt4914 @anandwana001 , I would like to work on Concept Card screen in this issue.

@alokbharti Assigned in description.

@anandwana001
Copy link
Contributor

@alokbharti any update on this?

@rt4914
Copy link
Contributor Author

rt4914 commented Jan 5, 2021

Assigned to @FareesHussain as it is blocked on his PR. #2274

@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added issue_type_enhancement Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_infrastructure labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@BenHenning BenHenning mentioned this issue Nov 15, 2022
Closed
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added the Work: Low Solution is clear and broken into good-first-issue-sized chunks. label Aug 10, 2023
@adhiamboperes adhiamboperes removed Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. labels Jan 24, 2024
@adhiamboperes adhiamboperes assigned theMr17 and Rd4dev and unassigned theMr17 Feb 27, 2024
@theMr17
Copy link
Collaborator

theMr17 commented Feb 27, 2024

As per my findings, text size settings is working fine for HintsAndSolutionDialogFragment inside an exploration. But this needs to be implemented for hints and solutions of question player.

Screen.Recording.mp4

@Rd4dev
Copy link
Collaborator

Rd4dev commented Feb 27, 2024

Hi @adhiamboperes, the existing implementation successfully updates the concept card text size along with changes in the reading text size, and I have included the recording for your reference. Is there anything specific that I may have overlooked or that still needs updating regarding the concept cards?

Asset:

Concept.card.reading.text.size.mp4

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Feb 29, 2024 •
edited
Loading

Thanks for testing this @theMr17 and @Rd4dev!

The only part of this left is to verify the text size in question player, but this isn't in use at the moment.

@theMr17
Copy link
Collaborator

theMr17 commented Feb 29, 2024

The only part of this left is to verify the text size in question player, but this isn't in use at the moment.

I had tested that part as well by changing feature flag values. The text size in question player is not in sync with the settings.

@adhiamboperes
Copy link
Collaborator

Thanks @theMr17!

@Vishwajith-Shettigar
Copy link
Collaborator

This issue similar to #4362, Updating PR to fix this issue.

@Vishwajith-Shettigar Vishwajith-Shettigar self-assigned this Apr 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vishwajith-Shettigar Vishwajith-Shettigar

Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone