Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stream_set_option() so that ClosureStream will work in PHP 7.4 #42

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Added stream_set_option() so that ClosureStream will work in PHP 7.4 #42

merged 1 commit into from
Nov 21, 2019

Conversation

davidbyoung
Copy link
Contributor

This partially addresses #41 by adding ClosureStream::stream_set_option(). The implementation is as recommended in the official upgrade guide.

@davidbyoung
Copy link
Contributor Author

Another question is whether or not we should add 7.4snapshot to .travis.yml. PHP 7.4 is coming out very soon, and it's probably best to make sure it works as expected there. With this PR, it should work minus support for short closures.

@msarca msarca merged commit 7a58440 into opis:master Nov 21, 2019
@jakzal jakzal mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbyoung @msarca