Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Add Camel-K operator #8

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Add Camel-K operator #8

merged 1 commit into from
Feb 11, 2019

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Jan 10, 2019 •
edited
Loading

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2019
@anik120 anik120 changed the title Add Camel-K operator [WIP] Add Camel-K operator Jan 10, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2019
@anik120 anik120 force-pushed the camel branch 5 times, most recently from 286bcc2 to 735176c Compare January 18, 2019 15:13
@anik120 anik120 force-pushed the camel branch 2 times, most recently from e4b28f6 to 8a45e1a Compare January 18, 2019 20:49
@anik120 anik120 changed the title [WIP] Add Camel-K operator Add Camel-K operator Jan 19, 2019
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2019
aravindhp
aravindhp suggested changes Jan 21, 2019
View reviewed changes
Copy link
Member

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate PR for the bundle

@aravindhp
Copy link
Member

/cc @tkashem

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 21, 2019
@anik120 anik120 force-pushed the camel branch 3 times, most recently from fc7c07e to 3e39c54 Compare January 21, 2019 21:51
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2019
@nicolaferraro nicolaferraro mentioned this pull request Jan 24, 2019
Closed
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2019
@anik120 anik120 force-pushed the camel branch 4 times, most recently from 743561b to a49c958 Compare February 8, 2019 21:06
@anik120
Copy link
Contributor Author

anik120 commented Feb 11, 2019

@tkashem @SamiSousa Addressed all comments. PTAL again.

SamiSousa
SamiSousa suggested changes Feb 11, 2019
View reviewed changes
community-operators/camel-k/camel-k.v0.1.0.clusterserviceversion.yaml Outdated
name: Example.java
```
keywords: ['apache', 'kamel', 'kubernetes', 'serverless', 'microservices']
version: 0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version should match the CSV version. Since the image is tagged 0.2.0 I suggest bumping the CSV to 0.2.0 to match

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamiSousa addressed.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 11, 2019
SamiSousa
SamiSousa approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@SamiSousa SamiSousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@SamiSousa
Copy link
Contributor

SamiSousa commented Feb 11, 2019 •
edited
Loading

@tkashem could you take a look at this? I want a second opinion before @anik120 makes a PR against the Camel-K operator repo

Add Camel-K operator
e30e315 
* Create community-operators/Camel-K directory to host csv, crds, and package yamls
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@SamiSousa
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@SamiSousa SamiSousa merged commit a74f166 into operator-framework:master Feb 11, 2019
@SamiSousa
Copy link
Contributor

Bundle pushed to quay at community-operators/camel-k

J0zi referenced this pull request in J0zi/community-operators Nov 12, 2019
@J0zi
try #8
8ce8ca9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tkashem tkashem tkashem requested changes

@aravindhp aravindhp aravindhp requested changes

@SamiSousa SamiSousa SamiSousa approved these changes

Assignees

@SamiSousa SamiSousa

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anik120 @aravindhp @tkashem @SamiSousa @openshift-ci-robot