Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clear hierarchy in the trace view #2195

Closed
drolando opened this issue Sep 25, 2018 · 1 comment · Fixed by #2736
Closed

More clear hierarchy in the trace view #2195

drolando opened this issue Sep 25, 2018 · 1 comment · Fixed by #2736
Labels

Comments

@drolando
Copy link
Contributor

Currently it's very difficult to tell whether 2 spans are siblings, parent - child or from 2 different subtrees. It's doable in small traces, but as you start having hundreds of spans it's hard to visually track the hierarchy.

The service name boxes (not sure how to call them) on the left kind of show the hierarchy, but they don't go very deep and it's still hard to tell whether 2 boxes with ~50 spans between them are at the same depth in the tree or not and whether they're actually related.

In my opinion it'd be useful to have even just something like ascii -- and | visually drawing the tree and connecting the spans.

example:

get /homepage
|-- select * from users
|-- get /is_user_authorized
|    |-- get /session_token
|         |-- select token from session_db;
|         |---- memcache set
|----------- update cookies
|----------- render template

Hopefully with CSS and Javascript you can come up with a better solution than my terrible ascii tree.

cc @zeagord

@tacigar
Copy link
Member

tacigar commented Nov 19, 2018

I think it is difficult to draw a vertical line over multiple <div>.
haystack-ui use <svg> for trace view, so they can draw lines flexibly in the vertical direction...
https://github.com/ExpediaDotCom/haystack-ui/blob/ee08389ba9d269eb19094c6c72d4d6c98baec964/src/components/traces/details/timeline/span.jsx#L203-L221

↓ haystack-ui
haystack-ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants