-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove « .html » extension #166
Comments
It is not that simple, or I miss something, this extension is necessary to make a distinction between the various file formats in the archive. For instance for book ID 18812 we have these three files now:
|
Ok, I didn't got this, all files would have an extension except for the HTML version. |
No, we'd still need the cover page so it won't be affected. @benoit74 beside the chrome urls (Home.html), the most important one is the cover and yes the HTML format version when it's included. To avoid conflicts yet keep decent-looking URLs I'd propose the following:
I am fine with the HTML format being named @kelson42 if you don't like it, please suggest another pattern ; keeping in mind:
|
@rgaudin Agree with your proposal. |
If it helps, I have code that will make a safe title based github-safe filename slug for any book in PG. |
hiii may i help by removing the « .html » extensions |
@prathamkumarjha ; yes, you can submit a PR , as per my comment above. |
These « .html » extensions, for example here https://library.kiwix.org/content/gutenberg_fr_all/A/Les%20Fleurs%20du%20Mal_cover.6099.html, were necessary at the time we were using zimwriterfs. Zimwriterfs neede this to identify HTML content which shoukd be indexed. This is not necessary anymore. There it should be simplified and removed for cleaner URLs and smaller ZIM size.
The text was updated successfully, but these errors were encountered: