Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Examples #38

Closed
lukasjhan opened this issue Dec 20, 2023 · 0 comments · Fixed by #39
Closed

Improve Examples #38

lukasjhan opened this issue Dec 20, 2023 · 0 comments · Fixed by #39
Assignees
@lukasjhan

Comments

@lukasjhan
Copy link
Member

Overview

  • I think the example should have comments to make it more understandable.
  • Fix example in readme
  • Add basic example in example projects
@lukasjhan lukasjhan self-assigned this Dec 20, 2023
lukasjhan added a commit to lukasjhan/sd-jwt-js that referenced this issue Dec 20, 2023
@lukasjhan
[openwallet-foundation-labs#38]Add comments on README example
413ca84 
Signed-off-by: Lukas <Lukas@hopae.io>
lukasjhan added a commit to lukasjhan/sd-jwt-js that referenced this issue Dec 20, 2023
@lukasjhan
[openwallet-foundation-labs#38]Improve examples
5c84d64 
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
@lukasjhan lukasjhan mentioned this issue Dec 20, 2023
Merged
@lukasjhan lukasjhan linked a pull request Dec 21, 2023 that will close this issue
[#38]Improve examples #39
Merged
aceshim added a commit to lukasjhan/sd-jwt-js that referenced this issue Dec 26, 2023
@aceshim
Merge branch 'main' into feature/openwallet-foundation-labs#38
92335ac
aceshim added a commit that referenced this issue Dec 26, 2023
@lukasjhan @aceshim
[#38]Improve examples (#39)
7c42704 
Signed-off-by: Lukas <Lukas@hopae.io>
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Co-authored-by: Jaehoon (Ace) Shim <ace@hopae.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasjhan lukasjhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#38]Improve examples lukasjhan/sd-jwt-js
1 participant
@lukasjhan