Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU]Fix qwen rope fusion with special_zero #24727

Merged
merged 3 commits into from
May 29, 2024
Merged

[CPU]Fix qwen rope fusion with special_zero #24727

merged 3 commits into from
May 29, 2024

Conversation

zhangYiIntel
Copy link
Contributor

@zhangYiIntel zhangYiIntel commented May 28, 2024 •
edited
Loading

Details:

Tickets:

@zhangYiIntel zhangYiIntel requested review from a team as code owners May 28, 2024 02:47
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label May 28, 2024
@zhangYiIntel zhangYiIntel mentioned this pull request May 28, 2024
Closed
@dmitry-gorokhov
Copy link
Contributor

@v-Golubev Please take a look. Thanks!

@dmitry-gorokhov dmitry-gorokhov added this to the 2024.2 milestone May 28, 2024
v-Golubev
v-Golubev approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@v-Golubev v-Golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only minor suggestions which don't affect the logic. I don't think that they block the merge: we can apply them in follow-up PR to master branch

src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/rope_fusion.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/rope_fusion.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/rope_fusion.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/tests/functional/custom/subgraph_tests/src/rotary_pos_emb.cpp Outdated Show resolved Hide resolved
@zhangYiIntel zhangYiIntel mentioned this pull request May 28, 2024
Merged
usstq
usstq approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@usstq usstq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue May 29, 2024
Merged via the queue into openvinotoolkit:releases/2024/2 with commit 3af803b May 29, 2024
111 checks passed
github-merge-queue bot pushed a commit that referenced this pull request May 29, 2024
@zhangYiIntel
[CPU]Fix Qwen Rope Fusion (#24750)
b66c43a 
### Details:
 - *Extend Qwen Rope Fusion*
- *PR to 2024.2 release
#24727
- *Migrate from original PR
#24725

### Tickets:
 - *CVS-142523*
allnes pushed a commit to allnes/openvino that referenced this pull request Jun 27, 2024
@zhangYiIntel @allnes
[CPU]Fix Qwen Rope Fusion (openvinotoolkit#24750)
73742bb 
### Details:
 - *Extend Qwen Rope Fusion*
- *PR to 2024.2 release
openvinotoolkit#24727
- *Migrate from original PR
openvinotoolkit#24725

### Tickets:
 - *CVS-142523*
sshlyapn pushed a commit to sshlyapn/openvino that referenced this pull request Jun 28, 2024
@zhangYiIntel @sshlyapn
[CPU]Fix Qwen Rope Fusion (openvinotoolkit#24750)
fb4e1ad 
### Details:
 - *Extend Qwen Rope Fusion*
- *PR to 2024.2 release
openvinotoolkit#24727
- *Migrate from original PR
openvinotoolkit#24725

### Tickets:
 - *CVS-142523*
sshlyapn pushed a commit to sshlyapn/openvino that referenced this pull request Jul 2, 2024
@zhangYiIntel @sshlyapn
[CPU]Fix Qwen Rope Fusion (openvinotoolkit#24750)
7b7127a 
### Details:
 - *Extend Qwen Rope Fusion*
- *PR to 2024.2 release
openvinotoolkit#24727
- *Migrate from original PR
openvinotoolkit#24725

### Tickets:
 - *CVS-142523*
@zhangYiIntel zhangYiIntel deleted the yi3/fix_qwen_rope branch July 25, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@usstq usstq usstq approved these changes

@v-Golubev v-Golubev v-Golubev approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

@v-Golubev v-Golubev

Labels
category: CPU OpenVINO CPU plugin Code Freeze
Projects
None yet
Milestone
2024.2
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangYiIntel @dmitry-gorokhov @usstq @v-Golubev