Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project level CVAT for images format import #980

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 28, 2023

Summary

  • Ticket no. 109743
  • While writing the OpenVINO blog posting draft, I found that importing the project level CVAT for images format is incorrect for an image path and the existing unit test has been not testing this.
  • Fix an incorrect image file path when importing the project level CVAT for images format dataset
  • This will be merged into releases/1.2.0 to make datumaro==1.2.1.

How to test

I updated the existing test also.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

 - Fix an incorrect image file path when importing the project level CVAT for images format dataset

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim changed the title Fix CVAT for images format import Fix project level CVAT for images format import Apr 28, 2023
@vinnamkim vinnamkim added BUG Something isn't working data formats PR is related to dataset formats labels Apr 28, 2023
@vinnamkim vinnamkim added this to the 1.2.0 milestone Apr 28, 2023
@vinnamkim vinnamkim marked this pull request as ready for review April 28, 2023 01:14
@vinnamkim vinnamkim requested review from a team as code owners April 28, 2023 01:14
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as draft May 2, 2023 04:20
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review May 2, 2023 05:06
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.01 ⚠️

Comparison is base (2b7fb35) 78.70% compared to head (20f3ee8) 78.70%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #980      +/-   ##
==================================================
- Coverage           78.70%   78.70%   -0.01%     
==================================================
  Files                 231      231              
  Lines               26420    26425       +5     
  Branches             5258     5260       +2     
==================================================
+ Hits                20795    20797       +2     
- Misses               4400     4401       +1     
- Partials             1225     1227       +2     
Flag Coverage Δ
macos-11_Python-3.8 77.72% <77.77%> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 78.67% <77.77%> (-0.02%) ⬇️
windows-2019_Python-3.8 78.58% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/cvat/base.py 91.66% <77.77%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vinnamkim vinnamkim merged commit 320ea82 into openvinotoolkit:releases/1.2.0 May 3, 2023
@vinnamkim vinnamkim deleted the bugfix/import-cvat-project branch May 3, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working data formats PR is related to dataset formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants