Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intermediate skills - Level 9: Dataset Explorartion from a Query Image/Text #959

Merged
merged 18 commits into from
Apr 20, 2023

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Apr 20, 2023

Summary

  • Ticket no. 108906
  • Add intermediate skills - Level 9: Data exploration
  • Rename searcher to explorer

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sooahleex sooahleex changed the base branch from develop to releases/1.2.0 April 20, 2023 02:45
@sooahleex sooahleex added the DOC Improvements or additions to documentation label Apr 20, 2023
@sooahleex sooahleex added this to the 1.2.0 milestone Apr 20, 2023
@sooahleex sooahleex marked this pull request as ready for review April 20, 2023 03:00
@sooahleex sooahleex requested review from a team as code owners April 20, 2023 03:00
Comment on lines -21 to -25
@skipIf(
platform.system() == "Darwin",
"Segmentation fault only occurs on MacOS: "
"https://github.com/openvinotoolkit/datumaro/actions/runs/4202399957/jobs/7324077250",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added below.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch coverage: 62.50% and no project coverage change.

Comparison is base (5095007) 78.70% compared to head (de3409b) 78.70%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.2.0     #959   +/-   ##
===============================================
  Coverage           78.70%   78.70%           
===============================================
  Files                 231      231           
  Lines               26420    26420           
  Branches             5258     5258           
===============================================
+ Hits                20794    20795    +1     
+ Misses               4401     4400    -1     
  Partials             1225     1225           
Flag Coverage Δ
macos-11_Python-3.8 77.73% <50.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 78.69% <62.50%> (+<0.01%) ⬆️
windows-2019_Python-3.8 78.59% <62.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/cli/commands/__init__.py 80.00% <ø> (ø)
datumaro/cli/commands/explore.py 27.27% <40.00%> (ø)
datumaro/components/explorer.py 55.68% <100.00%> (ø)
datumaro/plugins/explorer.py 85.45% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sooahleex sooahleex merged commit efd8a40 into openvinotoolkit:releases/1.2.0 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants