Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic skills - 02_dataset_download #935

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

vinnamkim
Copy link
Contributor

Summary

  • Change from sphinx_panels to sphinx-design
  • Update basic skills - 02_dataset_download

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…load

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review April 14, 2023 09:26
@vinnamkim vinnamkim requested review from a team as code owners April 14, 2023 09:26
@vinnamkim vinnamkim added this to the 1.2.0 milestone Apr 14, 2023
@vinnamkim vinnamkim added the DOC Improvements or additions to documentation label Apr 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f640c2c) 78.68% compared to head (2fa9d2f) 78.68%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.2.0     #935   +/-   ##
===============================================
  Coverage           78.68%   78.68%           
===============================================
  Files                 231      231           
  Lines               26408    26408           
  Branches             5257     5257           
===============================================
  Hits                20780    20780           
  Misses               4403     4403           
  Partials             1225     1225           
Flag Coverage Δ
macos-11_Python-3.8 77.71% <ø> (ø)
ubuntu-20.04_Python-3.8 78.66% <ø> (ø)
windows-2019_Python-3.8 78.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim changed the base branch from develop to releases/1.2.0 April 14, 2023 10:16
…load

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Copy link
Contributor Author

Resolved conflicts.

…load

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit cd9ba05 into openvinotoolkit:releases/1.2.0 Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants