Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validator and add notebooks and document for level-up validator #933

Merged
merged 9 commits into from
Apr 17, 2023

Conversation

wonjuleee
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Patch coverage: 93.93% and project coverage change: -0.05 ⚠️

Comparison is base (e6d73a0) 78.64% compared to head (5f6088b) 78.60%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #933      +/-   ##
==================================================
- Coverage           78.64%   78.60%   -0.05%     
==================================================
  Files                 228      231       +3     
  Lines               26349    26397      +48     
  Branches             5252     5254       +2     
==================================================
+ Hits                20723    20749      +26     
- Misses               4407     4422      +15     
- Partials             1219     1226       +7     
Flag Coverage Δ
macos-11_Python-3.8 77.63% <93.93%> (-0.04%) ⬇️
ubuntu-20.04_Python-3.8 78.58% <93.93%> (-0.05%) ⬇️
windows-2019_Python-3.8 78.48% <93.93%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/validators.py 90.17% <93.93%> (-0.71%) ⬇️

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wonjuleee wonjuleee changed the base branch from develop to releases/1.2.0 April 14, 2023 12:48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you tell us what you aimed to achieve by changing the code in this file? Just for refactoring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did, I tried to reuse some functions by refactoring.

tests/unit/test_validator.py Outdated Show resolved Hide resolved
@review-notebook-app
Copy link

review-notebook-app bot commented Apr 17, 2023

View / edit / reply to this conversation on ReviewNB

vinnamkim commented on 2023-04-17T02:05:32Z
----------------------------------------------------------------

Not to be fixed in this PR, but it seems that we need to discuss about dropping UndefinedAttribute from default Validator setting. This seems completely useless for the reallife usecase.


@review-notebook-app
Copy link

review-notebook-app bot commented Apr 17, 2023

View / edit / reply to this conversation on ReviewNB

vinnamkim commented on 2023-04-17T02:05:33Z
----------------------------------------------------------------

We need to make a requirement for enhancing Visualizer for this case .


@review-notebook-app
Copy link

review-notebook-app bot commented Apr 17, 2023

View / edit / reply to this conversation on ReviewNB

vinnamkim commented on 2023-04-17T02:05:34Z
----------------------------------------------------------------

It would be nice if the floating histogram was also provided by the Datumaro API.


Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit 26fba49 into openvinotoolkit:releases/1.2.0 Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants