Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negated property #907

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented Apr 3, 2023

Summary

Fixed wrong behaviour of is_encrypted property.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 added the BUG Something isn't working label Apr 3, 2023
@cih9088 cih9088 added this to the 1.2.0 milestone Apr 3, 2023
@cih9088 cih9088 requested a review from vinnamkim April 3, 2023 05:07
@cih9088 cih9088 requested review from a team as code owners April 3, 2023 05:07
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cih9088 cih9088 changed the title fix: correct return Fix negated property Apr 3, 2023
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8270e64) 78.90% compared to head (bd7f4a8) 78.90%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #907   +/-   ##
========================================
  Coverage    78.90%   78.90%           
========================================
  Files          211      211           
  Lines        25059    25059           
  Branches      5031     5031           
========================================
  Hits         19774    19774           
  Misses        4152     4152           
  Partials      1133     1133           
Flag Coverage Δ
macos-11_Python-3.8 77.89% <0.00%> (ø)
ubuntu-20.04_Python-3.8 ?
windows-2019_Python-3.8 78.84% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/media.py 83.46% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cih9088 cih9088 merged commit 80d16dc into openvinotoolkit:develop Apr 4, 2023
@cih9088 cih9088 deleted the fix/test-encrypted branch April 20, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants