Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move merge policies to datumaro/components/merge directory #906

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 30, 2023

Summary

  • Move merge policies (ExactMerge, IntersectMerge, and UnionMerge) to datumaro/components/merge directory

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review March 30, 2023 08:09
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.92% and project coverage change: +0.01 🎉

Comparison is base (0277fa8) 78.89% compared to head (a291b58) 78.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #906      +/-   ##
===========================================
+ Coverage    78.89%   78.90%   +0.01%     
===========================================
  Files          208      211       +3     
  Lines        25037    25059      +22     
  Branches      5031     5031              
===========================================
+ Hits         19752    19774      +22     
  Misses        4152     4152              
  Partials      1133     1133              
Flag Coverage Δ
macos-11_Python-3.8 77.89% <80.92%> (+0.01%) ⬆️
ubuntu-20.04_Python-3.8 ?
windows-2019_Python-3.8 78.84% <80.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/merge/__init__.py 38.46% <33.33%> (ø)
datumaro/components/merge/exact_merge.py 52.50% <52.50%> (ø)
datumaro/components/merge/union_merge.py 82.97% <82.97%> (ø)
datumaro/components/merge/intersect_merge.py 93.15% <93.15%> (ø)
datumaro/cli/commands/merge.py 20.20% <100.00%> (ø)
datumaro/components/hl_ops.py 64.51% <100.00%> (ø)
datumaro/components/operations.py 86.11% <100.00%> (+3.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim merged commit c976340 into openvinotoolkit:develop Mar 31, 2023
@vinnamkim vinnamkim deleted the refactor/merge-policy branch March 31, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants