Add multiprocessing to DatumaroBinaryBase #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #897 +/- ##
========================================
Coverage 78.86% 78.86%
========================================
Files 204 204
Lines 25002 25020 +18
Branches 5026 5031 +5
========================================
+ Hits 19718 19733 +15
- Misses 4151 4153 +2
- Partials 1133 1134 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
vinnamkim
force-pushed
the
feature/add-multiprocessing-to-datumaro-binary-import
branch
from
a0fe19c
to
ca504ea
Compare
JihwanEom
reviewed
Mar 28, 2023
sooahleex
previously approved these changes
Mar 28, 2023
| @@ -23,6 +23,7 @@ class DatumaroBinaryPath: | |||
| SECRET_KEY_FILE = "secret_key.txt" | |||
|
|
|||
| MAX_BLOB_SIZE = 2**20 # 1 Mega bytes | |||
| MP_TIMEOUT = 30.0 # 30 secs | |||
There was a problem hiding this comment.
Is there any reason to consider MP_TIMEOUT as 30 secs?
There was a problem hiding this comment.
No reason, I just put in a value that I feel moderately long.
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
JihwanEom
approved these changes
Mar 28, 2023
sooahleex
approved these changes
Mar 28, 2023
vinnamkim
deleted the
feature/add-multiprocessing-to-datumaro-binary-import
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--num-workersoption toDatumaroBinaryBasefor better performance.How to test
I updated the tests to cover this change.
Checklist
License
Feel free to contact the maintainers if that's a concern.