Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-media-encryption option #875

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 21, 2023

Summary

  • Ticket no. 106290
  • Add --no-media-encryption option to seperate two cases:
  1. A user wants to encrypt annotation and media both.
  2. A user wants to encrypt annotation only.

How to test

I added tests for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review March 21, 2023 06:56
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Mar 21, 2023
@vinnamkim vinnamkim added this to the 1.1.0 milestone Mar 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Patch coverage: 94.44% and no project coverage change.

Comparison is base (1f8e45e) 78.55% compared to head (28a26a0) 78.56%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.1.0     #875   +/-   ##
===============================================
  Coverage           78.55%   78.56%           
===============================================
  Files                 205      205           
  Lines               24943    24949    +6     
  Branches             5009     5009           
===============================================
+ Hits                19595    19601    +6     
  Misses               4222     4222           
  Partials             1126     1126           
Flag Coverage Δ
macos-11_Python-3.8 77.54% <94.44%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 ?
windows-2019_Python-3.8 78.49% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...o/plugins/data_formats/datumaro_binary/exporter.py 97.93% <87.50%> (+0.06%) ⬆️
datumaro/plugins/data_formats/datumaro/exporter.py 95.65% <100.00%> (ø)
...umaro/plugins/data_formats/datumaro_binary/base.py 93.42% <100.00%> (+0.27%) ⬆️
...aro/plugins/data_formats/datumaro_binary/format.py 88.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim merged commit fa7562c into openvinotoolkit:releases/1.1.0 Mar 22, 2023
@vinnamkim vinnamkim deleted the enhance/seperate-encryption-option branch March 22, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features RELEASE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants