Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MVTec format detect function #843

Merged
merged 8 commits into from
Mar 14, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 8, 2023

Summary

  • Ticket no. 105561

How to test

I changed the existing tests after fixing detectability for MVTec.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…p-priority-for-all-depths

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
 - Force to detect MVTec format only if MvtecPath.MASK_DIR directory
exists in the path.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added BUG Something isn't working data formats PR is related to dataset formats labels Mar 9, 2023
@vinnamkim vinnamkim added this to the 1.1.0 milestone Mar 9, 2023
@vinnamkim vinnamkim marked this pull request as ready for review March 13, 2023 02:11
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (f1c467a) 78.49% compared to head (619546f) 78.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #843      +/-   ##
===========================================
+ Coverage    78.49%   78.54%   +0.04%     
===========================================
  Files          196      196              
  Lines        24189    24231      +42     
  Branches      4907     4909       +2     
===========================================
+ Hits         18987    19032      +45     
+ Misses        4113     4110       -3     
  Partials      1089     1089              
Flag Coverage Δ
macos-11_Python-3.8 77.88% <100.00%> (+0.05%) ⬆️
ubuntu-20.04_Python-3.8 78.53% <100.00%> (+0.05%) ⬆️
windows-2019_Python-3.8 78.47% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/mvtec/importer.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim merged commit 21755d3 into openvinotoolkit:develop Mar 14, 2023
@vinnamkim vinnamkim deleted the bugfix/mvtec-detect branch March 14, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working data formats PR is related to dataset formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants