Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CIFAR10 and 100 detect function #836

Merged
merged 6 commits into from
Mar 9, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 7, 2023

Summary

  • Ticket no. 105476
  • Fix CIFAR-10 and CIFAR-100 detect function.

How to test

This change is covered by the existing tests.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added BUG Something isn't working data formats PR is related to dataset formats labels Mar 7, 2023
@vinnamkim vinnamkim marked this pull request as ready for review March 7, 2023 10:55
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (93df9d1) 78.46% compared to head (0d335e3) 78.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #836   +/-   ##
========================================
  Coverage    78.46%   78.47%           
========================================
  Files          196      196           
  Lines        24304    24320   +16     
  Branches      4946     4948    +2     
========================================
+ Hits         19071    19084   +13     
- Misses        4131     4133    +2     
- Partials      1102     1103    +1     
Flag Coverage Δ
ubuntu-20.04_Python-3.8 78.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/cifar.py 87.17% <100.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim added this to the 1.1.0 milestone Mar 8, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified find_sources() looks great.
I left a question about detect() function.

datumaro/plugins/data_formats/cifar.py Show resolved Hide resolved
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit 1003c25 into openvinotoolkit:develop Mar 9, 2023
@vinnamkim vinnamkim deleted the bug/fix-cifar-detect branch March 9, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working data formats PR is related to dataset formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants