-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed VGGFace2 #82
Fixed VGGFace2 #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most FR researchers usually align and crop faces before the training as a pre-process.
So in the training time, they only use images without the '.csv' file.
So how about generating Lable annotation even if '.csv' file isn't provided.
Or another way to handle this is to create a new extractor for the general FR dataset.
Isn't it exactly |
Technically you're right if ImageNet supports more image formats. |
@jihyeonyi, yes, it is strange. Actually, I think, we need to slightly change the structure of |
Good idea. I'm of the same opinion. |
@jihyeonyi, it definitely won't be done in this PR, more likely in Q1. |
label_name = item_id.split('/')[0] | ||
label = self._categories[AnnotationType.label].find(label_name)[0] | ||
if label is not None: | ||
item_id = item_id[len(label_name) + 1:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there can be no label directory prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If for example item.id = a/1 and there is no label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a folder for unlabeled items (like in ImageNet)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good idea, because otherwise we require labels.txt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only problem I see is that the former issue is not resolved.
Summary
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.