Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ellipse annotation type #807

Merged
merged 10 commits into from
Feb 10, 2023
Merged

Add Ellipse annotation type #807

merged 10 commits into from
Feb 10, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Feb 8, 2023

Summary

How to test

I updated the existing tests related to this change.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review February 8, 2023 08:29
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Feb 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 77.60% // Head: 77.67% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (6376b13) compared to base (3cc2e1c).
Patch coverage: 93.57% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #807      +/-   ##
===========================================
+ Coverage    77.60%   77.67%   +0.07%     
===========================================
  Files          179      179              
  Lines        23238    23335      +97     
  Branches      5023     5032       +9     
===========================================
+ Hits         18034    18126      +92     
- Misses        4141     4146       +5     
  Partials      1063     1063              
Flag Coverage Δ
macos-11_Python-3.10 ?
macos-11_Python-3.7 77.16% <93.00%> (+0.06%) ⬆️
macos-11_Python-3.8 77.54% <93.57%> (+0.07%) ⬆️
macos-11_Python-3.9 77.55% <93.57%> (+0.06%) ⬆️
ubuntu-20.04_Python-3.10 77.60% <93.57%> (+0.07%) ⬆️
ubuntu-20.04_Python-3.7 77.17% <93.00%> (+0.06%) ⬆️
ubuntu-20.04_Python-3.8 77.55% <93.57%> (+0.07%) ⬆️
ubuntu-20.04_Python-3.9 77.56% <93.57%> (+0.07%) ⬆️
windows-2019_Python-3.10 77.54% <93.51%> (+0.07%) ⬆️
windows-2019_Python-3.7 77.11% <92.92%> (+0.06%) ⬆️
windows-2019_Python-3.8 77.48% <93.51%> (+0.07%) ⬆️
windows-2019_Python-3.9 77.49% <93.51%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/transforms.py 76.72% <75.00%> (+0.03%) ⬆️
datumaro/components/visualizer.py 93.39% <87.50%> (+0.25%) ⬆️
datumaro/components/annotation.py 91.50% <91.80%> (+<0.01%) ⬆️
datumaro/__init__.py 100.00% <100.00%> (ø)
datumaro/components/filter.py 92.27% <100.00%> (+0.51%) ⬆️
datumaro/components/operations.py 84.07% <100.00%> (+0.06%) ⬆️
datumaro/plugins/data_formats/coco/exporter.py 86.17% <100.00%> (+0.08%) ⬆️
datumaro/plugins/data_formats/datumaro/base.py 93.61% <100.00%> (+0.09%) ⬆️
datumaro/plugins/data_formats/datumaro/exporter.py 92.95% <100.00%> (+0.13%) ⬆️
datumaro/plugins/validators.py 90.89% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me. I just left some minor comments.

datumaro/components/annotation.py Show resolved Hide resolved
datumaro/components/annotation.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@wonjuleee wonjuleee merged commit b8ddaf4 into develop Feb 10, 2023
@vinnamkim vinnamkim added this to the 1.0.0 milestone Feb 17, 2023
@vinnamkim vinnamkim deleted the feature/add-ellipse branch February 20, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants