Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for importing CVAT image 1.1 data format exported to project level #795

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 17, 2023

Signed-off-by: Kim, Vinnam vinnam.kim@intel.com

Summary

How to test

The test case for CVAT for images 1.1 format at project level is added.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added BUG Something isn't working data formats PR is related to dataset formats labels Jan 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Base: 83.95% // Head: 83.88% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (a9d4af6) compared to base (da67b52).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #795      +/-   ##
===========================================
- Coverage    83.95%   83.88%   -0.07%     
===========================================
  Files          173      173              
  Lines        22779    22746      -33     
  Branches      4951     4936      -15     
===========================================
- Hits         19124    19081      -43     
- Misses        2535     2541       +6     
- Partials      1120     1124       +4     
Flag Coverage Δ
macos-11_Python-3.10 83.80% <81.81%> (-0.07%) ⬇️
macos-11_Python-3.7 83.49% <81.25%> (-0.07%) ⬇️
macos-11_Python-3.8 83.74% <81.81%> (-0.06%) ⬇️
macos-11_Python-3.9 83.75% <81.81%> (-0.06%) ⬇️
ubuntu-20.04_Python-3.10 83.81% <81.81%> (-0.07%) ⬇️
ubuntu-20.04_Python-3.7 83.49% <81.25%> (-0.07%) ⬇️
ubuntu-20.04_Python-3.8 83.74% <81.81%> (-0.07%) ⬇️
ubuntu-20.04_Python-3.9 83.75% <81.81%> (-0.06%) ⬇️
windows-2019_Python-3.10 83.77% <81.81%> (-0.07%) ⬇️
windows-2019_Python-3.7 83.45% <81.25%> (-0.07%) ⬇️
windows-2019_Python-3.8 83.69% <81.81%> (-0.06%) ⬇️
windows-2019_Python-3.9 83.71% <81.81%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/cvat/base.py 91.47% <81.81%> (-4.62%) ⬇️
datumaro/plugins/splitter.py 88.47% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit 8452ee9 into openvinotoolkit:develop Feb 2, 2023
@vinnamkim vinnamkim changed the title Fix CVAT for images 1.1 data format import at project level Fix for importing CVAT image 1.1 data format exported to project level Feb 2, 2023
@vinnamkim vinnamkim mentioned this pull request Feb 2, 2023
7 tasks
@vinnamkim vinnamkim added this to the 1.0.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working data formats PR is related to dataset formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants